Code Review Roadmap

Step by step guide to becoming an Android developer.

Back to home

Legend

Propose
Alternatives
Options

1 Team-Wide General Practices

Document and standardize the code review process.
Ensure the purpose of code reviews is clear to everyone.
Ensure 'Definition of Done' is documented and clear to everyone.
Encourage team members to participate in code reviews.
Define a process for conflict resolution in code reviews.
Have a definitive style guide for style preferences.
Use automation to speed up code reviews (linting, sniffing, etc.)
Set clear expectations for code review turnaround times.

2 During Development (Author)

Follow the coding standards and any other team guidelines.
Self-review your code before submitting it for review.
Provide context for your changes and why they are necessary.
Keep Pull Requests small and focused.
Annotate your code to explain design decisions.

3 During the Review (Reviewer)

Understand the goals of the code changes.
Provide constructive and actionable feedback.
Be respectful and humble.
Ask questions instead of making statements.
Ensure that the code adheres to the team's standards and guidelines.
Look for logical errors and edge cases.
Provide positive feedback in addition to constructive criticism.

4 After the Review

Author:
Address all the feedback received.
Implement the suggested changes and provide explanations when needed.
Run the tests and ensure that they all pass after making changes.
Update any documentation or code comments affected.
Reviewer:
Verify that all the feedback has been addressed by the author.
Rerun the tests and ensure that they all pass.
After Approval:
Merge the approved code change into the main/feature branch.
Verify that the code change is functioning as expected in production.
Monitor the performance and functionality of the code change.